On Jan 11, 2011, at 3:33 PM, Matt Robinson wrote: > On Thu, Jan 6, 2011 at 9:12 AM, Luke Kanies <[email protected]> wrote: >> On Jan 6, 2011, at 9:02 AM, Matt Robinson wrote: >> >>> On Thu, Jan 6, 2011 at 2:38 AM, Brice Figureau >>> <[email protected]> wrote: >>>> On Wed, 2011-01-05 at 15:14 -0800, Matt Robinson wrote: >>>>> [snipped] >>>>> Also, we noticed that there's a Rakefile in the spec directory that >>>>> creates a bunch of rake tasks for every directory in spec. Is anyone >>>>> using this or care about it? We didn't upgrade it to work with RSpec2 >>>>> because we just noticed it and were hoping we could delete it. >>>> >>>> I did port this feature from the old test directory one. >>>> >>>> I sometimes use this feature to run only the unit tests and not the >>>> integration tests, but most of the time I'm running specs inside >>>> TextMate so I don't really care. >>> >>> Thanks for letting us know the source of this. I doubt many people >>> know it exists in either the spec or test directories, and if you >>> don't care much I'd just as soon get rid of it. Before I delete it >>> though I'll wait a bit to see if anyone else might ever use it. >> >> I used to use it a lot, and every time I've removed it, I've ended up adding >> it back in (as Brice has done here). >> >> Unless there's a serious maintenance cost to having it in there, I'd prefer >> it stay. It can make some kinds of debugging much easier, and I think >> overall it's a low cost to have. Maybe it could use some extra >> documentation or something, though. > > I started to upgrade this Rakefile today (the one in the spec > directory) and realized that rspec can already do the equivalent of > all the rake tasks this creates. I think all this Rakefile does is > give you rake tasks to run all the specs in some subdirectory. > Correct me if I'm missing some other useful thing it does. You can do > this same thing by simply passing the directory to rspec. > > `rake unit/property` is the same as `rspec unit/property` > > Luke, is that enough to convince you that we can get rid of the > Rakefile in the spec directory?
Yep. -- It isn't necessary to have relatives in Kansas City in order to be unhappy. -- Groucho Marx --------------------------------------------------------------------- Luke Kanies -|- http://puppetlabs.com -|- +1(615)594-8199 -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
