On Mon, Jan 24, 2011 at 13:52, nfagerlund <[email protected]> wrote:
>
> Signed-off-by: nfagerlund <[email protected]>
> ---
> lib/puppet/type/service.rb | 14 ++++++++++----
> 1 files changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/lib/puppet/type/service.rb b/lib/puppet/type/service.rb
> index c00f027..82affb6 100644
> --- a/lib/puppet/type/service.rb
> +++ b/lib/puppet/type/service.rb
> @@ -144,10 +144,16 @@ module Puppet
> specified."
> end
> newparam(:status) do
> - desc "Specify a *status* command manually. If left
> - unspecified, the status method will be determined
> - automatically, usually by looking for the service in the
> - process table."
> + desc "Specify a *status* command manually. This command must
> + return 0 if the service is running and a nonzero value otherwise.
> + Ideally, these return codes should conform to
> + [the LSB's specification for init script status
> actions](http://refspecs.freestandards.org/LSB_3.1.1/LSB-Core-generic/LSB-Core-generic/iniscrptact.html),
> + but puppet only considers the difference between 0 and nonzero
> + to be relevant.
> +
> + If left unspecified, the status method will be determined
> + automatically, usually by looking for the service in the process
> + table."
I would make that "...by looking for a process name that matches the
name of the puppet service resource name in the ..."
This confuses people, especially because some Linux distributions
package services that have different process names and service names.
(eg: httpd vs apache)
Regards,
Daniel
--
⎋ Puppet Labs Developer – http://puppetlabs.com
✉ Daniel Pittman <[email protected]>
✆ Contact me via gtalk, email, or phone: +1 (877) 575-9775
♲ Made with 100 percent post-consumer electrons
--
You received this message because you are subscribed to the Google Groups
"Puppet Developers" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/puppet-dev?hl=en.
