On Tue, Jan 25, 2011 at 10:39, Paul Berry <[email protected]> wrote:
> On Mon, Jan 24, 2011 at 11:24 PM, Luke Kanies <[email protected]> wrote:
>>
>> I guess my question is, who will normally be encountering this problem,
>> and how do we expect them to solve it?
>> My guess is that people who most commonly encounter this problem need an
>> insanely simple solution, and, um, telling them how easy it is to convert
>> the existing output into dot isn't it. :)
>>
>> Don't get me wrong -- your code is great and is shippable either way. But
>> if you feel like going that extra mile...
>>
>
> I agree with this. Compiling a catalog is fast enough that I imagine most
> users will want to fix the first error and then just try again (as most of
> us do when fixing syntax errors, for example). So I think it's ok to just
> display a single circular path (preferably the shortest one, but that's not
> critical).
I like promises, so I promise to deliver the shortest path; I don't
object to reducing the output to the first such path by default.
Changing it is literally a single default value in the code, so we can
revise this later if it turns out different in the real world.
> This has the advantage of making the error message as short and
> comprehensible as possible, so that users are more likely to read it and get
> benefit from it.
So, after the change we will report one path through every cycle
"cluster" of dependencies. This means that a dependency cluster that
includes a couple of unique paths will output only one of those, and
will require a second run to fix, but that two independent cycles will
only require a single run to find.
Regards,
Daniel
--
⎋ Puppet Labs Developer – http://puppetlabs.com
✉ Daniel Pittman <[email protected]>
✆ Contact me via gtalk, email, or phone: +1 (877) 575-9775
♲ Made with 100 percent post-consumer electrons
--
You received this message because you are subscribed to the Google Groups
"Puppet Developers" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/puppet-dev?hl=en.
