On 31.01.2011 20:11, Daniel Pittman wrote:
On Mon, Jan 31, 2011 at 10:50, Thomas Bellman<[email protected]> wrote:
James Turnbull wrote:
According to
http://pubs.opengroup.org/onlinepubs/009695399/basedefs/xbd_chap03.html#tag_03_266:
"Multiple successive slashes are considered to be the same as one
slash.", so '//tmp/xxx' is a valid POSIX pathname.
You should probably read section 3.2 then as well:
[...]
Posix has this rule to accomodate DomainOS, which was a Unix-
like OS from Apollo, where paths on the form "//foo/bar/gazonk"
meant the file "/bar/gazonk" on the machine named "foo". You may
recognize this format from URLs, or MS Windows SMB paths (with
backslashes instead of forward slashes).
Hah. You pipped me to the pedantic post, as I was working on this.
You should however not take this as me thinking the change is bad.
I actually think it is quite reasonable to allow such paths in
file resources. But maybe the commit message could be better. :-)
I was going to drop this in because it behaves correctly as far as end
users are concerned; I am going to additionally drop in a test to
verify that we preserve the double-slash at the start of the path.
(Currently pending, since I don't want to audit the entire codebase
yet.)
Now available in 2.6.next, along with the appropriate tests.
Please do consider windows support too, which actually uses an inital
double slash to detect UNC paths.
Best Regards, David
--
dasz.at OG Tel: +43 (0)664 2602670 Web: http://dasz.at
Klosterneuburg UID: ATU64260999
FB-Nr.: FN 309285 g FB-Gericht: LG Korneuburg
--
You received this message because you are subscribed to the Google Groups "Puppet
Developers" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/puppet-dev?hl=en.
