On Sun, Feb 13, 2011 at 01:22, Brice Figureau <[email protected]> wrote: > On 13/02/11 00:22, Daniel Pittman wrote:
[...] >> Hrm. So, it turns out that merging your github branch fails, but >> rebuilding the grammer with racc 1.4.6 works on my test system. Now >> it passes that test, so I can merge the outcome of that rebuild. >> Thanks for the hint: I should have tried that earlier, I guess, before >> giving up. > > That's the issue when doing grammar modifications: either I do them > serially (each one on top of the others) and you need to apply them in > order, or I do them independantly but you'd need to rebuild parser.rb > after every merge. The thing that surprised me is that there were no (as in, zero) merge conflicts on parser.rb from your github account into my branch. I would have expected that a mismatched rebuild would raise a bunch of them. :/ > There's no good solutions to this problem, though. Except I don't think > we should have parser.rb in git. But it's so more convenient this way > for our users (they don't have anything to build when they git clone). *nod* If I had a great solution I would raise it here. I honestly expected to see a clearer failure case from patching generated code, but obviously not. Which is certainly exciting. :) Daniel -- ⎋ Puppet Labs Developer – http://puppetlabs.com ✉ Daniel Pittman <[email protected]> ✆ Contact me via gtalk, email, or phone: +1 (877) 575-9775 ♲ Made with 100 percent post-consumer electrons -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
