Hi Daniel, On Sun, 2011-02-13 at 19:07 -0800, Daniel Pittman wrote: > G'day Brice. > > I have been staring at this on and off during the weekend, trying to > work out how to test it. Specifically, I really want to make sure > that this doesn't regress due to other changes in puppet if we drop it > in – it seems a very valuable behaviour fix, and worth preserving. > > Have you, or anyone else, an idea of how this could be unit-tested > effectively? I can probably write a reasonable enough integration > test to cover it, but that would be at a level that would risk a whole > bunch of sins slipping through...
As you already noticed, this part of the code is not covered by unit tests. I never managed to find the time to provide unit tests to this code. One of the reason is that it's quite complex because this code is really intertwined with RDoc code. The only solution I'm able to think about is to craft an integration test (modeling the one we already have for the rdoc parser). Then you need to exercise the Generators::MarkUp class to produce a link and check the link is conform. -- Brice Figureau Follow the latest Puppet Community evolutions on www.planetpuppet.org! -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
