On Fri, Feb 18, 2011 at 19:25, Daniel Pittman <[email protected]> wrote:
> From: Daniel Pittman <[email protected]>
>
> We now emit timing and output a status message at the end of a successful
> inspect run.
Almost all of this change is whitespace; the actual delta without is:
⚡ git diff 'HEAD^' -w
diff --git a/lib/puppet/application/inspect.rb
b/lib/puppet/application/inspect.rb
index 52ef975..764c8c4 100644
--- a/lib/puppet/application/inspect.rb
+++ b/lib/puppet/application/inspect.rb
@@ -98,6 +98,7 @@ Licensed under the GNU General Public License version 2
end
def run_command
+ benchmark(:notice, "Finished inspection") do
retrieval_starttime = Time.now
unless catalog = Puppet::Resource::Catalog.find(Puppet[:certname])
@@ -174,3 +175,4 @@ Licensed under the GNU General Public License version 2
end
end
end
+end
diff --git a/spec/unit/application/inspect_spec.rb
b/spec/unit/application/inspect_spec.rb
old mode 100644
new mode 100755
index 1d99c6c..d334a87
--- a/spec/unit/application/inspect_spec.rb
+++ b/spec/unit/application/inspect_spec.rb
@@ -174,7 +174,7 @@ describe Puppet::Application::Inspect do
@inspect.run_command
- @report.logs.count.should == 1
+ @report.logs.first.should_not == nil
@report.logs.first.message.should =~ /Could not back up/
end
end
...which is much smaller than it looked from that patch.
Regards,
Daniel
--
⎋ Puppet Labs Developer – http://puppetlabs.com
✉ Daniel Pittman <[email protected]>
✆ Contact me via gtalk, email, or phone: +1 (877) 575-9775
♲ Made with 100 percent post-consumer electrons
--
You received this message because you are subscribed to the Google Groups
"Puppet Developers" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/puppet-dev?hl=en.