On Tue, 2011-03-01 at 10:20 -0800, Matt Robinson wrote: > On Tue, Mar 1, 2011 at 5:29 AM, James Turnbull <[email protected]> wrote: > > James Turnbull wrote: > >> > >> diff --git a/lib/facter/util/virtual.rb b/lib/facter/util/virtual.rb > >> index 129448e..06b1b6d 100644 > >> --- a/lib/facter/util/virtual.rb > >> +++ b/lib/facter/util/virtual.rb > >> @@ -60,8 +60,8 @@ module Facter::Util::Virtual > >> > >> def self.jail? > >> path = case Facter.value(:kernel) > >> - when "FreeBSD": "/sbin" > >> - when "GNU/kFreeBSD": "/bin" > >> + when "FreeBSD" then "/sbin" > >> + when "GNU/kFreeBSD" then "/bin" > > > > Here I know: > > > > when foo then bar > > > > Can be written as: > > > > when foo; bar > > > > But I don't know which our preferred syntax is..? > > Our style guidelines are here: > http://projects.puppetlabs.com/projects/puppet/wiki/Development_Lifecycle#Style > which just reference the the unofficial Ruby style guidelines. Turns > out there's no mention of preference on this syntax issue and I'm fine > with that. I don't think it's worth caring one way or the other, do > what you like best.
There has been intermittent discussion of dropping "then" as well as ":" for 2.0, so the ":" --> ";" change is probably better. -- M -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
