Great patch set, Daniel - well done.

On Mar 3, 2011, at 4:42 PM, Daniel Pittman wrote:

> Ages back we moved from Test::Unit to RSpec based testing as our primary
> mechanism; at the time we ported a bunch of tests over that still depended on
> the old infrastructure.
> 
> One of the key things this introduces is global "fixture" helpers, especially
> "my_fixture" and "my_fixtures", which magically work out the right place to
> find your fixtures.  This makes a solid convention for where to find per-spec
> data, which makes it easier to use.
> 
> This patch series does that, along with a cherry-pick of a fix for a test hang
> from 2.6.x, and a couple of other tiny test fixes along the way.
> 
> The original purpose of the series was to enable the use of specjour[1] to run
> tests in parallel, which turns out to be pretty unreliable.  However, the
> series is of stand-alone value in cleaning up the test suite, and gives us
> some valuable features.
> 
> (Incidentally, using specjour let me reduce the 3:30 average runtime to :34
> for the entire spec suite on my machine plus one extra CPU, when it ran
> successfully.  The issue was reproducing that without spurious failures of
> communication between the test nodes.)
> 
> Regards,
>    Daniel
> 
> [1] https://github.com/sandro/specjour
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Puppet Developers" group.
> To post to this group, send email to [email protected].
> To unsubscribe from this group, send email to 
> [email protected].
> For more options, visit this group at 
> http://groups.google.com/group/puppet-dev?hl=en.
> 


-- 
The hypothalamus is one of the most important parts of the brain,
involved in many kinds of motivation, among other functions. The
hypothalamus controls the "Four F's": 1. fighting;  2. fleeing;
3. feeding; and  4. mating.
          -- Psychology professor in neuropsychology intro course
---------------------------------------------------------------------
Luke Kanies  -|-   http://puppetlabs.com   -|-   +1(615)594-8199




-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Developers" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-dev?hl=en.

Reply via email to