Peter Meier wrote: >> I've deliberately changed this because the original use of mode from >> policy is totally wrong IMHO. I've reached out to the original author >> for some feedback on why he chose that but I suspect if anyone is using >> it (and I doubt it) the change won't be substantive as you rarely have a >> mode in config that differs from the running mode - at least not for long. > > As you suspected me to be the original author and as you are probably right: > > This might be one of my very first pieces of code for facter. > Furthermore, my knowledge with SELinux isn't anymore that uptodate and > it haven't even been at that time. (I used to do a lot of SELinux in its > very early days). > > Therefor, I would say that you all are probably right. > >>> Yeah - poorly defined fact purposes bite us again. I'd say for 1.5.x >>> we might want to maintain old behaviour to not break policy type >>> clients and breaking changes when we break the world in 2.0. > > As we have the situation that (A) the fact is wrong (B) at least I don't > use it (that have originally written it) we should at least introduce a > correct fact (like selinux_current_mode) in the next release. But I > think we could probably even dump the old one. > > Thanks for fixing and cleaning that up!
Pete I might just re-write it again and add facts for everything outputted that default to nil if the output isn't there :) Thanks for getting back to me. James -- James Turnbull Puppet Labs 1-503-734-8571 -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
