On 14 March 2011 16:52, Daniel Pittman <dan...@puppetlabs.com> wrote:
> On Sun, Mar 13, 2011 at 19:57, James Turnbull <ja...@lovedthanlost.net> wrote:
>>
>> Signed-off-by: James Turnbull <ja...@lovedthanlost.net>
>> ---
>> Local-branch: tickets/master/6695
>> lib/facter/id.rb | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/lib/facter/id.rb b/lib/facter/id.rb
>> index c2c3594..f3de1a9 100644
>> --- a/lib/facter/id.rb
>> +++ b/lib/facter/id.rb
>> @@ -1,5 +1,5 @@
>> Facter.add(:id) do
>> - confine :operatingsystem => %w{Linux Fedora RedHat CentOS SuSE SLES
>> Debian Ubuntu Gentoo AIX OEL OVS GNU/kFreeBSD windows}
>> + confine :operatingsystem => %w{Linux Fedora RedHat CentOS SuSE SLES
>> Debian Ubuntu Gentoo AIX OEL OVS GNU/kFreeBSD windows Darwin NetBSD FreeBSD
>> OpenBSD}
>> setcode "whoami"
>> end
>
> It would be really good to see some tests to verify that we keep
> delivering this fact on the appropriate platforms added; we have a
> real habit of making changes to Facter without testing, and that model
> leads to regressions later...
Having CI jobs for previous and past release calling ext/facter-diff
to check for regressions should help. What is the status of
hudson/jenkins and puppet/facter these days?
Paul
--
You received this message because you are subscribed to the Google Groups
"Puppet Developers" group.
To post to this group, send email to puppet-dev@googlegroups.com.
To unsubscribe from this group, send email to
puppet-dev+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/puppet-dev?hl=en.
