On Mon, Mar 28, 2011 at 02:12:48PM -0700, Jacob Helwig wrote: > On Tue, 22 Mar 2011 23:35:10 +0100, Stefan Schulte wrote: > [...] > The original version also allowed 'ddp' (even though it wasn't > documented). Should this version allow it, too? I just want to make > sure this change is intentional and desired. Looks like it might have > been in there to support AppleTalk networks (Datagram Delivery Protocol)? > [...]
I want to support ddp, but I dont own a Mac. And I was a bit afraid of
a comment in the original provider:
# We're cheating horribly here -- we don't support ddp, because it assigns
# the same number to already-used names, and the same name to different
# numbers.
text_line :ddp, :match => /^\S+\s+\d+\/ddp/
# Also, just ignore the lines on OS X that don't have service names.
text_line :funky_darwin, :match => /^\s+\d+\//
If someone can test the new type/provider on OS X or can send me a services
file so I can add a testcase I would be really happy.
> [...]
> > +
> > + it "should send the first value to the provider for number property" do
> > + number = @class.attrclass(:number).new(:resource => @resource,
> > :should => %w{100 200})
> > + @provider.expects(:number=).with '100'
> > + number.sync
> > + end
>
> This is purely my own ignorance, but: Why is this particular
> test/behavior important?
>
It's not ;-)
I just wasnt sure how puppet and the OrderedList property behave. I will
kick these tests out. (I think I got the "inspiration" for that test in
unit/type/user_spec.rb section "when syncing")
Thank you for all your comments so far.
-Stefan
pgpcv55pRnCj1.pgp
Description: PGP signature
