I like the general not-stupidness of the patch, but it really should go through the standard logging infrastructure, not just call puts. We should either raise the level of the log message so it will display / record by default, or perhaps adjust log output levels temporarily.
Daniel On Tue, Apr 5, 2011 at 00:05, Ben Hughes <[email protected]> wrote: > On Tue, Apr 05, 2011 at 04:27:13PM +1000, Ben Hughes wrote: > >> Always output the fingerprint to STDOUT, no matter what loglevel is used, >> as that's the whole purpose of the comment. > > Ironically, this breaks the unit test entitled "Puppet::Application::Agent > when running with --fingerprint should display the fingerprint" which it > technically wasn't doing before. Better patch forthcoming. > > -- > Ben Hughes || http://www.puppetlabs.com/ > > -- > You received this message because you are subscribed to the Google Groups > "Puppet Developers" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/puppet-dev?hl=en. > > -- ⎋ Puppet Labs Developer – http://puppetlabs.com ✉ Daniel Pittman <[email protected]> ✆ Contact me via gtalk, email, or phone: +1 (877) 575-9775 ♲ Made with 100 percent post-consumer electrons -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
