On Tue, Apr 26, 2011 at 02:30, Jeff McCune <[email protected]> wrote:
> On Mon, Apr 25, 2011 at 9:20 PM, Pieter van de Bruggen
> <[email protected]> wrote:
>> Reviewed-By: Matt Robinson
>>
>> Signed-off-by: Pieter van de Bruggen <[email protected]>
>
> May I also request the commit message contain a bit more information?
> Reading this out of context as I process email, I have the following
> questions. Is the commit message a reasonable place to expect this
> sort of information, or is there a better place to look for it?
Generally, the commit message should include enough information to
understand the change, yes. :)
> * How is this change meant to be used?
> * When should I use this over the previous way of doing things?
So, to be clear: we are still discussing the approach internally, but
I suspect that it won't emerge in this form, or at least not formally
in the language yet, until we better understand how to, well, answer
these questions. :)
> * Why are we making this change? (Maybe just a quick copy / paste from
> the ticket?)
> * Do I need to refactor any of my faces actions based on this commit?
> e.g. is it a significant API change?
Yah. There *shouldn't* be substantial API changes that require you to
refactor any work you are doing by this point in the process.
Incompatible changes to the API are now going to be held until 2.8, or
whatever the next major version past this one are.
Compatible API changes, and possibly some semantics that are currently
undefined, or "as it happens to be written" defined might happen, but
we will be treating them as seriously as we consider any change that
touches on code compatibility.
Regards,
Daniel
--
⎋ Puppet Labs Developer – http://puppetlabs.com
✉ Daniel Pittman <[email protected]>
✆ Contact me via gtalk, email, or phone: +1 (877) 575-9775
♲ Made with 100 percent post-consumer electrons
--
You received this message because you are subscribed to the Google Groups
"Puppet Developers" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/puppet-dev?hl=en.
