----- Original Message ----- > R.I.Pienaar wrote: > > From: Dan Carley <[email protected]> > > I didn't do anything other than glance at this, but here are some > very minor things that I noticed.
Thanks, The main aim with the patch is to solve a little issue where sometimes the old script would result in 2 daemons running instead of 1, using the rh builtin helpers work around that. So I think it would be acceptable to park this refactoring - and no doubt other EPEL related package tasks of which I expect there to be many - till after 1.2.0 is out so we can try get that one into EPEL. > > > --- a/mcollective.init > > +++ b/mcollective.init > > @@ -1,12 +1,12 @@ > > #!/bin/sh > > # > > -# mcollective Application Server for STOMP based agents > > +# mcollective Application Server for STOMP based agents > > # > > -# chkconfig: 345 24 76 > > +# chkconfig: 345 24 76 > > This may not matter since this isn't an init script for a package > being submitted to EPEL/RHEL/Fedora, but typically, daemons are made > to not start by default. That avoids folks just installing the > package one day, forgetting about it, and then realizing it's been > listening on the network for a long time in an unconfigured state. > > Perhaps: > > > -# chkconfig: 345 24 76 > > +# chkconfig: - 24 76 > > is better? > > Similarly, Default-Start and Default-Stop in the LSB header may be > desirable to leave out. > > > -# description: mcollective lets you build powerful Stomp > > compatible middleware clients in ruby without having to worry too > > -# much about all the setup and management of a Stomp > > connection, it also provides stats, logging and so forth > > -# as a bonus. > > +# description: mcollective lets you build powerful Stomp > > compatible middleware clients in ruby without having to worry too > > +# much about all the setup and management of a Stomp > > connection, it also provides stats, logging and so forth > > +# as a bonus. > > For the chkconfig header, wrapped lines in the description section > should be backslash escaped. > > -- > Todd OpenPGP -> KeyID: 0xBEAF0CE3 | URL: > www.pobox.com/~tmz/pgp > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > People are crazy and times are strange > I'm locked in tight, I'm out of range > I used to care, but things have changed > > -- R.I.Pienaar -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
