You got me. I just use 'git send-email' and stuff, because it lets me do the right thing. :)
Daniel On Wed, May 11, 2011 at 17:02, ajsharp <[email protected]> wrote: > How do I attach a new/revised patch to this email thread with the > mail_patches rake task? > > On May 10, 11:50 am, markus <[email protected]> wrote: >> > > Yea, you're probably right. FWIW, here's the offending block of code >> > > in lib/puppet/interface/option_builder.rb:19: >> >> > [...] >> > > Puppet::Interface::Option.instance_methods.grep(/=$/).each do | >> > > setter| >> > > next if setter =~ /^=/ >> > > dsl = setter.to_s.sub(/=$/, '') >> >> > Yeah, that looks right to me. :) >> >> You might want to intern it (since it was originally a symbol and the >> proposed code leaves it as a string): >> >> dsl = setter.to_s.sub(/=$/, '').intern >> >> -- Markus >> >> P.S. I don't think a monkey patch to add Symbol#sub is too bad either, >> especially since it future-proofs the code a little bit. > > -- > You received this message because you are subscribed to the Google Groups > "Puppet Developers" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/puppet-dev?hl=en. > > -- ⎋ Puppet Labs Developer – http://puppetlabs.com ✉ Daniel Pittman <[email protected]> ✆ Contact me via gtalk, email, or phone: +1 (877) 575-9775 ♲ Made with 100 percent post-consumer electrons -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
