Even if the discussion had been on the list, we should have a better commit message explaining why a revert is being done, and there still ought to be a reviewer. http://projects.puppetlabs.com/projects/puppet/wiki/Development_Lifecycle#Commit+Messages
On Thu, May 12, 2011 at 4:07 PM, Daniel Pittman <[email protected]> wrote: > On Thu, May 12, 2011 at 15:59, Jacob Helwig <[email protected]> wrote: >> On Thu, 12 May 2011 15:55:10 -0700, Daniel Pittman wrote: >>> >>> This reverts commit 9329a1f33b4d7df81ad8661de74f8a3656428570. >>> >>> Conflicts: >>> >>> spec/unit/interface/action_builder_spec.rb >>> spec/unit/interface/action_spec.rb >>> --- >>> lib/puppet/interface/action.rb | 5 -- >>> lib/puppet/interface/action_builder.rb | 10 ---- >>> spec/unit/interface/action_builder_spec.rb | 62 >>> ---------------------------- >>> spec/unit/interface/action_spec.rb | 59 >>> -------------------------- >>> 4 files changed, 0 insertions(+), 136 deletions(-) >>> >> >> So, uh...why is this being reverted? > > I thought the discussion had been on this list, but apparently not. > https://projects.puppetlabs.com/issues/7220 now has the explanation of > why this is being reverted. > > Daniel > -- > ⎋ Puppet Labs Developer – http://puppetlabs.com > ✉ Daniel Pittman <[email protected]> > ✆ Contact me via gtalk, email, or phone: +1 (877) 575-9775 > ♲ Made with 100 percent post-consumer electrons > > -- > You received this message because you are subscribed to the Google Groups > "Puppet Developers" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/puppet-dev?hl=en. > > -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
