Hi,

----
DISCLAIMER: This is my first contribution to puppet as well as the first 
message to the ML, if I should have done something differently, please let me 
know!
----

I have a provided a patch (well, actually it is a fork ;-) to add virtualenv 
support to the pip provider; this is the relative issue: 
https://projects.puppetlabs.com/issues/7286

Actually there are two points which prevent me to submit the patch:

1) I added a "virtualenv" parameter to the package type, but Dominic suggested 
to adapt the root parameter already present on this type. What is the general 
advice on this? Is it better to have different parameters with a clear semantic 
or is it better to avoid cluttering the type with too many parameters?

2) I provided some tests, but don't know it they are sufficient and I was not 
able to run them (well, actually any puppet test) on my machine.

Thank you for any advice!

~JJ

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Developers" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-dev?hl=en.

Reply via email to