This is great to see. It's complicated enough that it's tough to see how much it will actually affect, but it's great to see this amount of reduction in complexity.
On May 13, 2011, at 2:31 PM, Nick Lewis wrote: > This commit unifies some paths in the grammar, which had previously been > duplicated to avoid shift/reduce conflicts. Merging these paths together and > separating only the conflicting structures leads to a cleaner grammar, with > fewer holes. > > Several bugs are fixed as a result: > (#3129) Nested class names beginning with numbers work correctly > (#5268) Hyphens in class names work correctly > (#5817) Hashes and arrays can now be passed to functions (hashes require > parentheses) > > Additionally, expressions are now legal in most places where they would make > sense, when previously only bare rvalues were allowed. > > Paired-With: Markus Roberts > Reviewed-By: Matt Robinson > > Signed-off-by: Nick Lewis <[email protected]> > --- > Local-branch: ticket/next/7523 > lib/puppet/parser/grammar.ra | 94 +- > lib/puppet/parser/lexer.rb | 10 +- > lib/puppet/parser/parser.rb | 2119 ++++++++++++++------------------ > spec/integration/parser/parser_spec.rb | 31 + > spec/unit/parser/lexer_spec.rb | 44 +- > 5 files changed, 1020 insertions(+), 1278 deletions(-) [...] -- No one who cannot rejoice in the discovery of his own mistakes deserves to be called a scholar. --Donald Foster --------------------------------------------------------------------- Luke Kanies -|- http://puppetlabs.com -|- http://about.me/lak -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
