On Mon, May 16, 2011 at 14:02, R.I.Pienaar <[email protected]> wrote:
> Allow . in fact names

This doesn't seem sufficient to me: facter, at least, defines the fact
name as "any arbitrary string, after String#downcase", which means
that this is still substantially more restrictive than one of the
underlying libraries it models.

It also lacks tests, and the commit message that is too short to hit
our coding standards.  Those need to be cleaned up before this can go
into the code.

Thanks,
    Daniel
-- 
⎋ Puppet Labs Developer – http://puppetlabs.com
✉ Daniel Pittman <[email protected]>
✆ Contact me via gtalk, email, or phone: +1 (877) 575-9775
♲ Made with 100 percent post-consumer electrons

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Developers" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-dev?hl=en.

Reply via email to