On May 18, 2011, at 11:14 PM, James Turnbull <[email protected]> wrote:
> This patch set is some code Joel Rosario made available in 2009 to support > users and groups on Windows. > > I've updated it slightly and rebased it against master. > > I've tested it and it seems to be working but it might not be the optimal > approach to the problem - > especially the use of the util/windows_system.rb helper methods which might > be better as an iteration > of nameservice for example. This is awesome, thanks. In looking rough the patches, it looks like they could all be squashed into one patch, or maybe two. The majority of them modify code provided in a patch earlier in the series, which is always a candidate for squashing. It's hard to comment on any given patch because you kind of have to comment back from the top - any given line is probably overridden by a later patch. -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
