On Thu, 02 Jun 2011 17:48:15 +1000, Nathan Norton wrote: > > Hello, > > First commit so be gentle ;) > > This patch is for ticket 2247 and enabling repos in the yum provider > > Nathan >
Nathan, Thanks for taking the time to put this together. I don't think we can actually accept this patch series as is, however. We require all contributors to have submitted a signed CLA, and it doesn't look like Matthew Byng-Maddick has done that as far as I can tell. Since your first commit uses the patch he submitted, we'd need a CLA from him as well. The commits all look like they really should have been squashed down into a single commit, especially since we generally want the tests to go into the same commit as the functionality that introduces them. Unless you're adding pending tests that fail[1] before adding the functionality and marking the tests as no longer pending. Just my personal opinion: I think we're actually better off implementing #4113[2] in the long-run. If we can get the CLA from Matthew, and squash down the commit series then we should be able to get this moving forward relatively quickly (ignoring the issue of whether to go with #2247 or #4113). I'll open up a new thread on puppet-users, and puppet-dev to try and get more discussion around whether people would rather we go with #2247 or #4113. I'd rather not block this on my personal opinion if it's in the minority. Again: Thanks for putting in the time to put this together. [1] http://relishapp.com/rspec/rspec-core/v/2-6/dir/pending/pending-examples [2] http://projects.puppetlabs.com/issues/4113 -- Jacob Helwig
signature.asc
Description: Digital signature
