On Mon, Jun 20, 2011 at 5:31 PM, Josh Cooper <[email protected]> wrote:
> diff --git a/app/models/delayed_job_failure.rb 
> b/app/models/delayed_job_failure.rb
> new file mode 100644
> index 0000000..c046d75
> --- /dev/null
> +++ b/app/models/delayed_job_failure.rb
> @@ -0,0 +1,5 @@
> +class DelayedJobFailure < ActiveRecord::Base
> +  def self.per_page; 25 end
> +
> +  named_scope :unread, :conditions => { :read => nil }

It seems like this would be good to have non-nullable, with a default
of false, and true meaning read. Even in trying to write this comment,
I find myself unable to wrap my mind around which of true, false, and
nil for 'read' mean this is 'unread'. It looks like both read = true
and read = false result in not being unread, and read = nil is unread.

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Developers" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-dev?hl=en.

Reply via email to