On Tue, 21 Jun 2011 11:03:21 -0700, Adrien Thebo wrote: > > Refactored lib/facter/manufacturer.rb and > lib/facter/util/manufacturer.rb to conform more closely to the general > facter style. Manufacturer facts were moved out of the utility class and > changed into independent fact blocks, and use confines instead of > if/else blocks to confine facts to specific operatingsystem. > > In the manufacturer utility module, removed unneeded utility methods, > simplified DMI querying to make it more general purpose, and cleaned up > the dmi table accessor. Refactored the accompanying unit tests and moved > raw test data into fixture files. > > Signed-off-by: Adrien Thebo <[email protected]> > --- > Local-branch: ticket/master/7142 > lib/facter/manufacturer.rb | 100 ++++++++++++++------ > lib/facter/util/manufacturer.rb | 115 ++++------------------ > spec/unit/data/dmi_match_section | 28 ++++++ > spec/unit/data/dmi_split_handle | 12 +++ > spec/unit/manufacturer_spec.rb | 44 +++++++++ > spec/unit/util/manufacturer_spec.rb | 180 > +++++++++++------------------------ > 6 files changed, 230 insertions(+), 249 deletions(-) > create mode 100644 spec/unit/data/dmi_match_section > create mode 100644 spec/unit/data/dmi_split_handle > create mode 100644 spec/unit/manufacturer_spec.rb >
Adrien, Could you rebase this against the latest master? It doesn't apply cleanly at all. -- Jacob Helwig
signature.asc
Description: Digital signature
