Please review pull request #370: (#9160) Change logging facility to debug for not supported provider features opened by (fpletz)
Description:
- Opened: Sat Jan 21 20:01:16 UTC 2012
- Based on: puppetlabs:master (71ef29ddcfe1317f12aaf4ba41792f2b00375929)
- Requested merge: fpletz:fix-9160 (fb12c29274e8eeccafbf91d0bac10c0624fbc6d5)
Diff follows:
diff --git a/lib/puppet/type.rb b/lib/puppet/type.rb
index 3cb32c4..176084f 100644
--- a/lib/puppet/type.rb
+++ b/lib/puppet/type.rb
@@ -485,7 +485,7 @@ def newattr(name)
if provider and ! provider.class.supports_parameter?(klass)
missing = klass.required_features.find_all { |f| ! provider.class.feature?(f) }
- info "Provider %s does not support features %s; not managing attribute %s" % [provider.class.name, missing.join(", "), name]
+ debug "Provider %s does not support features %s; not managing attribute %s" % [provider.class.name, missing.join(", "), name]
return nil
end
diff --git a/test/ral/manager/attributes.rb b/test/ral/manager/attributes.rb
index 8b0b8df..c3e449e 100755
--- a/test/ral/manager/attributes.rb
+++ b/test/ral/manager/attributes.rb
@@ -227,7 +227,7 @@ def test_newattr_and_required_features
no.each do |a|
assert_nil(resource.should(a), "Got value for unsupported %s in %s" % [a, prov.name])
if Puppet::Util::Log.sendlevel?(:info)
- assert(@logs.find { |l| l.message =~ /not managing attribute #{a}/ and l.level == :info }, "No warning about failed %s" % a)
+ assert(@logs.find { |l| l.message =~ /not managing attribute #{a}/ and l.level == :debug }, "No warning about failed %s" % a)
end
end
-- You received this message because you are subscribed to the Google Groups "Puppet Developers" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to [email protected].
For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
