Please review pull request #144: Allow multiple exitcodes for initial puppet agent run opened by (justinstoller)

Description:

Prior to this (a change I made to not effectively bounce
the agent service) only accepted an exit code of 0.

This worked for my testing because of conditions that caused
the agent to check in once before the test was actually ran.
The issue is when (and this is the typical case in CI) the test
is the first agent run to check in there will usually be
successful changes applied and puppet will exit with 2.

This adds 2 as an acceptable exit code.

Signed-off-by: Justin Stoller [email protected]

  • Opened: Sat Feb 11 00:15:51 UTC 2012
  • Based on: puppetlabs:master (0d86568b39055e5e24166fab72f00665566e89c4)
  • Requested merge: justinstoller:more_robust_agents (10cb4650d06b82e98e6a0ef69f99025c4c58c0ee)

Diff follows:

diff --git a/setup/pe/05_Agent_test.rb b/setup/pe/05_Agent_test.rb
index 20e9d04..06f2e74 100755
--- a/setup/pe/05_Agent_test.rb
+++ b/setup/pe/05_Agent_test.rb
@@ -3,4 +3,4 @@
 
 sleep 20
 
-on agents, puppet_agent('--test')
+on agents, puppet_agent('--test'), :acceptable_exit_codes => [0,2]

    

--
You received this message because you are subscribed to the Google Groups "Puppet Developers" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to [email protected].
For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.

Reply via email to