Please review pull request #153: (maint) fix xml output opened by (justinstoller)
Description:
In a previous commit I unified the reporting of test status numbers. There was a typo in the usage of these in the TestSuite#write_junit_xml. This fixes that.
- Opened: Thu Feb 23 21:02:11 UTC 2012
- Based on: puppetlabs:master (74b0530276c4e60e38ccf1e1b1205923832a099e)
- Requested merge: justinstoller:maint_fix_xml_output (3dd6b68556c55900d836bd688577a828b9b14066)
Diff follows:
diff --git a/lib/test_suite.rb b/lib/test_suite.rb
index a276712..a565940 100644
--- a/lib/test_suite.rb
+++ b/lib/test_suite.rb
@@ -142,9 +142,9 @@ def write_junit_xml
suite = REXML::Element.new('testsuite', doc)
suite.add_attribute('name', name)
suite.add_attribute('tests', test_count)
- suite.add_attribute('errors', errored_test)
- suite.add_attribute('failures', failed_test)
- suite.add_attribute('skip', skipped_test)
+ suite.add_attribute('errors', errored_tests)
+ suite.add_attribute('failures', failed_tests)
+ suite.add_attribute('skip', skipped_tests)
suite.add_attribute('pending', pending_tests)
@test_cases.each do |test|
-- You received this message because you are subscribed to the Google Groups "Puppet Developers" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to [email protected].
For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
