Please review pull request #21: cleanup example manifest to make puppet-lint pass opened by (jedi4ever)

Description:

As I include this module in my puppet-lint tests, this kinda feels dirty.

So here's the cleanup.

  • Opened: Wed Apr 04 18:05:13 UTC 2012
  • Based on: puppetlabs:master (54be04bb999004d34f19a0482299d017556604af)
  • Requested merge: jedi4ever:puppet_lint_cleanup (b24de954dc2d95c933fe32dc36ee12200e6a0912)

Diff follows:

diff --git a/example/modules/data/manifests/common.pp b/example/modules/data/manifests/common.pp
index c49b05e..9a7d414 100644
--- a/example/modules/data/manifests/common.pp
+++ b/example/modules/data/manifests/common.pp
@@ -1,3 +1,3 @@
 class data::common {
-   $ntpservers = ["ntp1.example.com", "ntp2.example.com"]
+  $ntpservers = ['ntp1.example.com', 'ntp2.example.com']
 }
diff --git a/example/modules/ntp/manifests/config.pp b/example/modules/ntp/manifests/config.pp
index 0d84963..8981784 100644
--- a/example/modules/ntp/manifests/config.pp
+++ b/example/modules/ntp/manifests/config.pp
@@ -1,5 +1,5 @@
-class ntp::config($ntpservers = hiera("ntpservers")) {
-    file{"/tmp/ntp.conf":
-        content => template("ntp/ntp.conf.erb")
+class ntp::config($ntpservers = hiera('ntpservers')) {
+    file{'/tmp/ntp.conf':
+        content => template('ntp/ntp.conf.erb')
     }
 }
diff --git a/example/modules/ntp/manifests/data.pp b/example/modules/ntp/manifests/data.pp
index 2a43072..e1aa0e5 100644
--- a/example/modules/ntp/manifests/data.pp
+++ b/example/modules/ntp/manifests/data.pp
@@ -1,3 +1,3 @@
 class ntp::data {
-    $ntpservers = ["1.pool.ntp.org", "2.pool.ntp.org"]
+    $ntpservers = ['1.pool.ntp.org', '2.pool.ntp.org']
 }
diff --git a/example/modules/users/manifests/common.pp b/example/modules/users/manifests/common.pp
index 5b297b2..01c50eb 100644
--- a/example/modules/users/manifests/common.pp
+++ b/example/modules/users/manifests/common.pp
@@ -1,3 +1,3 @@
 class users::common {
-    notify{"Adding users::common": }
+    notify{'Adding users::common': }
 }
diff --git a/example/modules/users/manifests/dc1.pp b/example/modules/users/manifests/dc1.pp
index 11e11b9..5b0b857 100644
--- a/example/modules/users/manifests/dc1.pp
+++ b/example/modules/users/manifests/dc1.pp
@@ -1,3 +1,3 @@
 class users::dc1 {
-    notify{"Adding users::dc1": }
+    notify{'Adding users::dc1': }
 }
diff --git a/example/modules/users/manifests/development.pp b/example/modules/users/manifests/development.pp
index 193ec01..abcdae4 100644
--- a/example/modules/users/manifests/development.pp
+++ b/example/modules/users/manifests/development.pp
@@ -1,3 +1,3 @@
 class users::development {
-    notify{"Adding users::development": }
+    notify{'Adding users::development': }
 }
diff --git a/example/site.pp b/example/site.pp
index 156e390..57e844d 100644
--- a/example/site.pp
+++ b/example/site.pp
@@ -1,3 +1,3 @@
 node default {
-    hiera_include("classes")
+    hiera_include('classes')
 }

    

--
You received this message because you are subscribed to the Google Groups "Puppet Developers" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to [email protected].
For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.

Reply via email to