Please review pull request #626: (#13639) Don't send errors directly to stderr opened by (kelseyhightower)
Description:
Use Puppet#err and not $stderr to log error messages.
- Opened: Thu Apr 05 05:18:30 UTC 2012
- Based on: puppetlabs:2.7.x (d88f3e7c387eff270101604f2fec2e086f88ebdd)
- Requested merge: kelseyhightower:ticket/2.7.x/13639_use_puppet_logging_not_stderr (28531f814a9736bf1fd84a1324b4ab0a7baf5c3d)
Diff follows:
diff --git a/lib/puppet/forge/repository.rb b/lib/puppet/forge/repository.rb
index fd92b7d..cacfdc6 100644
--- a/lib/puppet/forge/repository.rb
+++ b/lib/puppet/forge/repository.rb
@@ -74,7 +74,7 @@ def read_response(request)
msg = "Error: Could not connect to #{@uri}\n"
msg << " There was a network communications problem\n"
msg << " Check your network connection and try again\n"
- $stderr << msg
+ Puppet.err msg
exit(1)
end
end
-- You received this message because you are subscribed to the Google Groups "Puppet Developers" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to [email protected].
For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
