On Wednesday, April 11, 2012, Ken Barber wrote: > Hi all, > > So I've been trying to work on Facter version pinning for the next > release of Puppet, based on a discussion with Daniel - it was deemed > we might want to pin Telly -> Facter 2.0.
Will Facter be semantic versioned and does the 2.0.0 version (it won't be 2.0) mean it won't be backwards compatible with Facter 1.6? > I've made a few changes to get this going ... firstly, I added a > feature, which does semver comparisons. This change is here: > > > https://github.com/kbarber/puppet/commit/db458c68fb6c03497ecf61c21a026233b5e828d3 > > The real problem however, is deciding the right point to do this check > :-). I've tried something in this commit: > > > https://github.com/kbarber/puppet/commit/8332529f1085f0418743c462e80fb043c1d82225 > > But quite frankly its horrible - and obviously requires one to include > the check at multiple points. This would in most cases be a nightmare > for face developers as well, as they would have to make their own > decision about weither they require Facter. Seems like it should just be in puppet.rb or maybe puppet/facter.rb to abstract it. You should expect that simply loading Facter (or any library) isn't expensive at all. If it is expensive then Facter likely is doing the wrong thing, like loading facts or what not. https://github.com/kbarber/puppet/blob/master/lib/puppet.rb ? > My question is - does anybody have a better place to do this check? > I've tried different places and ran into ordering issues myself, and > found this to be effective but potentially ideal. I have considered > again Luke's patch to abstract facter as a possibility, even though > initially we lacked cases for this - it might be that _this_ is the > reason for it: > > https://github.com/puppetlabs/puppet/pull/144 > > Also any opinion on this entire concept would be welcome. > > ken. > > -- > You received this message because you are subscribed to the Google Groups > "Puppet Developers" group. > To post to this group, send email to [email protected]<javascript:;> > . > To unsubscribe from this group, send email to > [email protected] <javascript:;>. > For more options, visit this group at > http://groups.google.com/group/puppet-dev?hl=en. > > -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
