Groovy - should we get a ticket in for win32console & 1.9.3 support to remind us? I obviously want to get on with other facter stuff for now - so I wouldn't mind an understanding as to when its needed.
On Mon, Apr 16, 2012 at 5:14 PM, Josh Cooper <[email protected]> wrote: > Nice work Ken! For 2.7.x, puppet on windows only supports 1.8.7, so I think > we should be good. > > Daniel has done a bunch of work to add 1.9.3 support in Telly, so I think > that's something to be resolved "soon" but not immediately. If you could > look into that, that'd be great. > > I've created a ticket to colorize console output for puppet on Windows: > http://projects.puppetlabs.com/issues/13956 > > Josh > > On Sun, Apr 15, 2012 at 5:43 PM, Ken Barber <[email protected]> wrote: >> >> Good news - this has been merged and released. win32console 1.3.1 with >> the background/foreground preservation is now available via gem >> install. >> >> However, there are 1.9.3 issues, seemingly in the C code I would read >> from his comment. He is open to more patches if we want this solved - >> let me know if you want me to tackle this now. >> >> On Wed, Apr 11, 2012 at 9:42 AM, Ken Barber <[email protected]> wrote: >> > So I think I've now met the authors requirements for merging. The ETA >> > for next release of win32console with this patch is this weekend, and >> > this should include a new public gem as well. >> > >> > https://github.com/luislavena/win32console/pull/12 >> > >> > I'm assuming this is our way of moving forward with color, and will >> > adapt a methodology for working with that gem for windows color in >> > Facter. Thanks everyone for your help so far. >> > >> > On Tue, Apr 10, 2012 at 3:46 PM, Ken Barber <[email protected]> wrote: >> >> Good news, looks like the author is willing to take a patch if I fix >> >> tests. >> >> >> >> On Apr 10, 2012 11:40 AM, "Ken Barber" <[email protected]> wrote: >> >>> >> >>> Bah - forgot the screenshots. Left is powershell, right is command >> >>> prompt. As you can see, it preserves the background blue now. >> >>> >> >>> On Tue, Apr 10, 2012 at 11:32 AM, Ken Barber <[email protected]> >> >>> wrote: >> >>> > Nice :-). Turns out someone had already done this in a clone. Here >> >>> > is >> >>> > my branch that includes those patches: >> >>> > >> >>> > https://github.com/kbarber/win32console/tree/fix_background_color >> >>> > >> >>> > I just rebased, and added better documentation around building from >> >>> > source. If someone has the time, it would be good to confirm this >> >>> > works for Puppet. >> >>> > >> >>> > I've raised a pull request here: >> >>> > >> >>> > https://github.com/luislavena/win32console/pull/12 >> >>> > >> >>> > ... petitioning him to take the patch and do another release, lets >> >>> > see >> >>> > how we go. If he is reluctant we could possibly ask if we could take >> >>> > on maintaining the gem as well. Not sure what people want to do here >> >>> > - >> >>> > but if this gem is important to us then we should do the right thing >> >>> > somehow. >> >>> > >> >>> > ken. >> >>> > >> >>> > On Mon, Apr 9, 2012 at 6:18 PM, Ken Barber <[email protected]> >> >>> > wrote: >> >>> >>> I think we should go with win32console, file a ticket about the >> >>> >>> background >> >>> >>> issue, and either submit a pull request to Luis or fork our own >> >>> >>> version and >> >>> >>> patch it there. If this sounds reasonable, I'll file the ticket. >> >>> >>> >> >>> >>> And Ken, it sounds like you already know what the fix would be. Is >> >>> >>> this >> >>> >>> something you can work on? >> >>> >> >> >>> >> Happy to work on the patch Josh. >> >>> >> >> >>> >> ken. >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Puppet Developers" group. >> To post to this group, send email to [email protected]. >> To unsubscribe from this group, send email to >> [email protected]. >> For more options, visit this group at >> http://groups.google.com/group/puppet-dev?hl=en. >> > > > > -- > Josh Cooper > Developer, Puppet Labs > > -- > You received this message because you are subscribed to the Google Groups > "Puppet Developers" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/puppet-dev?hl=en. -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
