Please review pull request #752: (#14391) Fix inaccurate message from Hiera data lookups opened by (kelseyhightower)
Description:
When the Hiera gem is missing the error message now reads:
"Hiera terminus not supported without hiera library"
- Opened: Thu May 10 00:59:06 UTC 2012
- Based on: puppetlabs:master (5582168fa5911a4761db0cd4f025d805cb2ff933)
- Requested merge: kelseyhightower:master (55bb107dae7ac9ff4c39b05ab302616a6b0ccabd)
Diff follows:
diff --git a/lib/puppet/indirector/hiera.rb b/lib/puppet/indirector/hiera.rb
index b36be06..2e2905e 100644
--- a/lib/puppet/indirector/hiera.rb
+++ b/lib/puppet/indirector/hiera.rb
@@ -3,7 +3,7 @@
class Puppet::Indirector::Hiera < Puppet::Indirector::Terminus
def initialize(*args)
if ! Puppet.features.hiera?
- raise "Hiera terminus not supported without hiera gem"
+ raise "Hiera terminus not supported without hiera library"
end
super
end
diff --git a/spec/unit/indirector/hiera_spec.rb b/spec/unit/indirector/hiera_spec.rb
index e7cd5f7..e114c31 100644
--- a/spec/unit/indirector/hiera_spec.rb
+++ b/spec/unit/indirector/hiera_spec.rb
@@ -51,7 +51,7 @@ module Testing; end
it "should raise an error if we don't have the hiera feature" do
Puppet.features.expects(:hiera?).returns(false)
lambda { @hiera_class.new }.should raise_error RuntimeError,
- "Hiera terminus not supported without hiera gem"
+ "Hiera terminus not supported without hiera library"
end
describe "the behavior of the find method", :if => Puppet.features.hiera? do
-- You received this message because you are subscribed to the Google Groups "Puppet Developers" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to [email protected].
For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
