Please review pull request #763: Bug/2.7.x/14440-rake-manpages opened by (cprice-puppet)
Description:
Because we have not done a good job of defining
state initialization life cycle when we try to use
puppet as API, we need to add a hack to the rake
manpage task so that it can generate man pages
for some faces that don't get properly initialized
w/o the hack.
- Opened: Fri May 11 20:43:59 UTC 2012
- Based on: puppetlabs:2.7.x (4c6648ad4ba154abece8f45ee1e4518867e53820)
- Requested merge: cprice-puppet:bug/2.7.x/help-faces-as-api (dae5539a9c68363606a0c2014357a2b3ce5b59e4)
Diff follows:
diff --git a/tasks/rake/manpages.rake b/tasks/rake/manpages.rake
index 00a4f1e..460521c 100644
--- a/tasks/rake/manpages.rake
+++ b/tasks/rake/manpages.rake
@@ -7,6 +7,16 @@ task :gen_manpages do
helpface = Puppet::Face[:help, '0.0.1']
manface = Puppet::Face[:man, '0.0.1']
+
+ # TODO: This line is terrible. The reason we need this here is because we
+ # handle state initialization differently when we run via command line
+ # (application.rb) than we do when we try to use Faces as library code.
+ # This is bad, we need to come up with an official stance on what our
+ # API is and what the entry points, so that we can make sure that
+ # state initialization is consistent. See:
+ # http://projects.puppetlabs.com/issues/14441
+ Puppet::Util::Instrumentation.init()
+
sbins = Dir.glob(%w{sbin/*})
bins = Dir.glob(%w{bin/*})
non_face_applications = helpface.legacy_applications
-- You received this message because you are subscribed to the Google Groups "Puppet Developers" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to [email protected].
For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
