Please review pull request #98: (#5879) Remove finder on obsolete URL column opened by (MaxMartin)
Description:
This commit removes a finder method from the reports controller that
referenced the URL field on nodes, since URL was removed from the nodes
table with a migration earlier this year. This lead to several customers
having issues that left them unable to add new nodes to their
infrastructure. It is not known why this has not caused more widespread
problems (and frankly, I find it kind of mysterious). Either way, this
fix has been tested by customers, and has resolved their issues.
- Opened: Mon May 14 21:49:00 UTC 2012
- Based on: puppetlabs:master (55193fce1d112f06c0e161a16b83200b22f4ceab)
- Requested merge: MaxMartin:ticket/master/5879-node-finder (75f00bed430b31c05ffa2aa5188167d9147c4627)
Diff follows:
diff --git a/app/controllers/reports_controller.rb b/app/controllers/reports_controller.rb index 01d0d9a..60132f4 100644 --- a/app/controllers/reports_controller.rb +++ b/app/controllers/reports_controller.rb @@ -1,5 +1,5 @@ class ReportsController < InheritedResources::Base - belongs_to :node, :optional => true, :finder => :find_by_url! + belongs_to :node, :optional => true protect_from_forgery :except => [:create, :upload] before_filter :raise_if_enable_read_only_mode, :_only_ => [:new, :edit, :update, :destroy]
-- You received this message because you are subscribed to the Google Groups "Puppet Developers" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to [email protected].
For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
