On 12-06-26 07:08 PM, Ken Barber wrote:
Hey all,
Sorry - last newbie question for the night.
I wanted to see what peoples thoughts were around when an acceptance
test is required, there was a debate on a ticket recently and two
people told me it wasn't necessary to add acceptance tests for a
particular case - and my mother told me when enough people tell you
that you are wrong, you probably should start questioning yourself
:-). The particular case itself is irrelevant here, what I'm more
interested in is discussing peoples views on when an acceptance test
is necessary or optional.
Which case it that? Do you happen to have the issue number so I can
read the arguments?
So - when do people think its necessary? Is there a rule people
follow? I'm really after objective arguments here, if they exist. I'm
not sure if all the devs in Puppetlabs are on the same page, but some
pointers around _when_ its a good idea from anyone who has an opinion
would really help me out.
For me, you need to decided what you are trying to solve. A problem
with regressions in release branches, new features going into master or
security issues. I think the hardest part is trying to determine which
scenario you add them in, and which you don't. Honestly, I'm of the
mind set it doesn't matter. Every time you make a change to code, you
should be adding a test too.
Now, if developers don't see the value in adding them, I think there is
a bigger issue. Is it because they don't want too or just because of the
amount of time it takes to add and test them? Again, ideally it would
be easy to drop new tests into puppet and have them executed.
Also, you might just need to be more stubborn in you merging policy too.
Limit how merging is done, and expect develops to follow a code review
policy. It might help to automate the merging (bot?) policy only after
the code review process is signed off properly.
To be honest I've not followed how puppet-dev manages it's code, testing
and release policies (I plan to read up on it soon(tm)) however I
believe looking to how other project handle the same issue is also a
good way to get new ideas. Specifically, I've been watching OpenStack's
dev team more and more theses days any trying to implement some of their
policies some of my branches. They seem to have some good ideas on this
subject too.
--
Paul Belanger | PolyBeacon, Inc.
Jabber: [email protected] | IRC: pabelanger (Freenode)
Github: https://github.com/pabelanger | Twitter:
https://twitter.com/pabelanger
--
You received this message because you are subscribed to the Google Groups "Puppet
Developers" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/puppet-dev?hl=en.
