On Jul 5, 2012, at 2:23 PM, Brice Figureau wrote: > On 05/07/12 19:01, Daniel Pittman wrote: >> On Thu, Jul 5, 2012 at 9:56 AM, Luke Kanies <[email protected]> >> wrote: >>> On Jul 5, 2012, at 9:49 AM, Andrew Parker wrote: >>> >>>> As Deepak said, we are taking a look over Brice's patches right >>>> now. Initially we'll target them at 3.0 and then we'll probably >>>> move on to back porting and tuning a bit on 2.7 after we have 3.0 >>>> stabilized. At the same time we have been taking a look at the >>>> catalog retrieval time problem. Based on the discussion that we >>>> had a while ago on this list, I think the plan of attack is to >>>> remove the YAML translation for the caching. I haven't seen any >>>> numbers for the speed improvement that we get for that yet. >>> >>> Peter Meier has shown that storying to yaml takes at least a minute >>> and often 2-3 minutes on his systems, and that same catalog is >>> transferred in json over the wire to his agents, which takes a >>> negligible amount of time. So, while we don't have a bunch of >>> independent runs showing the specific wins, I think we have enough >>> anecdotal data that we can be sure. >> >> I should note that the architecture of the indirector makes it >> absolutely impossible to simply save that pre-encoded JSON, so we >> still end up going through a decode, encode cycle to get it to disk >> - just a faster one. > > Yes, that's too bad. Depending on what we're losing in performance it > might be acceptable to introduce some specificities for the catalog > indirection that takes care of capturing to disk the json representation > when the agent downloads it, and then later move this in place of the > current cache.
Note that one of the reasons I didn't fix this years ago was I kept trying to find the time to fix it the right way but never succeeded, so instead I left the bad code in. Far better to fix it ugly than leave it bad but pretty, so I'm happy to hear that's what's being done, at least for now. We can worry about the ugly later, let's get the fast now. :) -- Luke Kanies | http://about.me/lak | http://puppetlabs.com/ | +1-615-594-8199 -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
