On Tue, Jul 31, 2012 at 7:42 PM, Andy Parker <[email protected]> wrote:

> Would that make it easier for you? The change on our end would be that
> github pull requests would just be a staging area for code and we often
> wouldn't use it for merging (which is not a big loss).

I think that might be a positive change in that I love using pull requests for
work in progress.  It's an ideal way to send something to Puppetlabs developers
as a kind of request for feedback.  If that's what you mean by staging area for
code then I think that's probably ideal.  People work in master and
then Puppetlabs
merge things back to stable branches.

I guess I'd like to see github become more of a back and forth on git pulls at
earlier stages rather than just being where you issue a pull request
for complete
and finished patches, so this change would play nicely with that.
Plus sometimes
the code changes between the tip of development and stable branches can be
fairly significant so it makes sense that people always work against development
and then that work is merged back if appropriate.  It seems confusing to try to
develop against the oldest branch and then make Puppetlabs do a bunch of
work to merge it into newer and newer branches.

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Developers" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-dev?hl=en.

Reply via email to