On Wednesday, September 12, 2012 2:06:37 AM UTC+10, Andy Parker wrote:
>
>
> Welcome and thanks for helping out.
>
Thanks!
> > * I would begin by refactoring util/processor.rb a little moving
> iterative
> > code to the top, all Facter.add blocks after this, and standardise
> naming of
> > 'ProcessorCount' using camel case. I would do this in a single commit?
> >
>
> I would do that in two commits. Partly because as much as
> standardizing the naming would be good, it might have to get dropped
> so as to not break uses of it. Smaller, targeted commits are usually
> better than larger ones.
>
Okay, I assume the case doesn't actually matter because processor.rb has
examples of both. Which is preferred - lower case or camel case?
> > if processor_list.length != 0
> > processor_list.each_with_index do |desc, i|
> > Facter.add("Processor#{i}") do
> > confine :kernel => [ :linux, :"gnu/kfreebsd", :aix, :sunos ]
> > setcode do
> > desc
> > end
> > end
> > end
> > end
>
> I don't think you need to preserve those `if processor_list.length`
> checks. Just call the `each_with_index` and if the list is empty
> nothing will happen.
>
I see, noted.
> I would open another bug or find something that already exists to
> track adding the HP-UX facts. #11612 seems like it might be closely
> related.
>
Yes, you are absolutely right; I didn't see that. That makes it a bit more
complicated. I have looked through the code in
https://github.com/puppetlabs/facter/pull/232 now and I could use much of
that code and extend it to PA-RISC and the versions of HP-UX I have. It
has status "tests insufficient" and no one is assigned, though. It seems
more sensible that I continue working with that branch - is that possible?
Can I somehow be assigned to the issue, assuming no one is working on it?
--
You received this message because you are subscribed to the Google Groups
"Puppet Developers" group.
To view this discussion on the web visit
https://groups.google.com/d/msg/puppet-dev/-/cOuDF8BK_DoJ.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/puppet-dev?hl=en.
