On Mon, Dec 17, 2012 at 3:53 PM, Alex Harvey <[email protected]> wrote:
> > > On Tuesday, December 11, 2012 6:20:54 PM UTC+11, Josh Cooper wrote: > >> In cases were I find a Windows fact is wrong, e.g. architecture[2], >> domain[3], I've taken the route that it's better to fix the bug and >> make it consistent with other platforms, than to not do so for fear of >> making a backwards incompatible change. With that said, it's good to >> think about the impact changing a fact's semantics will have, and >> whether the benefit outweighs the pain. In the case of the domain >> fact, Windows nodes with a primary dns suffix, but no >> connection-specific suffixes were reporting an empty domain. Clearly >> fixing the fact was the right thing to do, but it meant users had to >> regenerate their windows agent certificates (due to the default >> certname being based on the fqdn). >> > > It seems to me that if we agree that we need to fix this eventually then > the sooner it's fixed, the less the chance that new manifests will be > written using the old, broken behaviour. That said I'm not the one who > faces the Solaris customers when they upgrade facter and potentially find > their manifests no longer work. So with that in mind ... shall I proceed > to raise a bug and 'fix' this? > Because this change would be backwards-incompatible, SemVer requires that version with the fix increments the major version number, so this would have to go into 2.0.0. -- > You received this message because you are subscribed to the Google Groups > "Puppet Developers" group. > To view this discussion on the web visit > https://groups.google.com/d/msg/puppet-dev/-/Yuv6GOFPnqYJ. > > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/puppet-dev?hl=en. > -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
