Hi all, I've sat down to write physicalprocessorcount for HP-UX and found I'd like to call a method machinfo that I've put in util/processor.rb. The processorX and processorcount facts however live in lib/facter/processor.rb whereas physicalprocessorcount lives in lib/facter/physicalprocessorcount.rb and are self-contained.
I could, I suppose, have physicalprocessorcount.rb also require util/processor.rb but it makes more sense to me to have all processor-related facts inside processor.rb and let that continue to require methods in util/processor.rb. Thus it makes sense to me to refactor first and combine physicalprocessorcount.rb and processor.rb in a single file. The latter file, after all, already contains two processor-related facts - why should physicalprocessorcount be special? However, before I venture too far down this path I guess I should check if anyone objects - so would it be okay if my patch for #17520 includes one commit that refactors as proposed and another that adds the HP-UX physicalprocessorcount fact? TIA, Alex -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To view this discussion on the web visit https://groups.google.com/d/msg/puppet-dev/-/3Zl9n8F2GjkJ. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
