On Fri, Jan 25, 2013 at 9:41 AM, Gavin Williams <[email protected]> wrote:
> I've just pushed an updated code set to > https://github.com/fatmcgav/puppet-oracle/commits/oranfstab_dev > > Thoughts before I plow on too much further? > I recommend trying to avoid using `class << oranfstab`, the so called "eigenclass" or "singleton class" is quite magical and really tripped me up when I was first learning Puppet and Ruby. It might be more direct and clear for other readers to create a new class that's a subclass of String in order to implement the `to_line` method. At the top of the file you could then create the strings using OranString.new('/var/opt/oracle/oranfstab') and OranString.new('/etc/oranfstab'). I've got a meeting to run off to, but are there other specific areas of this that you'd like us to focus our feedback on? -Jeff -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. Visit this group at http://groups.google.com/group/puppet-dev?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
