On Thu, Feb 14, 2013 at 7:01 AM, Lukas Hetzenecker <
[email protected]> wrote:

> Hi guys,
>
> i developed a module for puppet that handles the ssh key management in a
> saner way.
> The biggest shortcomings of the ssh_authorized_key resource are listed in
> Puppet bug #1531 and should be fixed with this approach.
>

Awesome.


> Could a developer have a look at this code? Would it be possible to
> include it in a future release of Puppet?
>

I've taken a look and it looks pretty good.  We could definitely include it
in Puppet core, but it would need to fully replace the ssh_authorized_key
type in Puppet.

A better approach may be to remove the ssh_authorized_key type from Puppet
entirely and host your module on the Puppet Forge.  Over time, we're hoping
Puppet core gets slimmer instead of bigger.

Finally, I recommend implementing some way to automatically exercise the
behavior that you expect from this type and provider.  rspec-puppet is the
most common way to exercise and check your expectations.

Keep up the good work!

-Jeff

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/puppet-dev?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to