HI Ikka, thanks for the note.
This project has its own mailing list ([email protected]) for future reference. On Tue, Mar 5, 2013 at 7:28 AM, Ilkka Tengvall <[email protected]> wrote: > I noticed puppetlabs/openstack and puppetlabs/cinder sets the cinder > volume group inconsistently. It allows setting the volume group name in > controller node (iscsi) config, but it leaves it unchanged on a controller > node. I changed the modules a bit to allow setting the name consistenlty > also on controller cinder.conf. > clearly this is an issue. There are a couple of pull requests that I am currently working on that look like they may be solving this problem (although not exactly in the same way you propose) https://github.com/puppetlabs/puppetlabs-openstack/pull/171/files > > Setting the volume group name to something unique like $hostname-cinder is > useful for the case in debugging if something goes wrong, and there are > several cinder volume groups within the same lvm host, or in virtualization > setup of kvm + controller as guest. > > Please consider the patch for inclusion. I can provide it on github also > if that helps, please do, that is where patches are discussed right now. Just be sure you have the pull requests reference each other. > I just didn't know wether this would fall under openstack or cinder > project. > > BR, > > Ilkka Tengvall // cybercom.com > > > Index: modules/openstack/manifests/controller.pp > =================================================================== > --- modules/openstack/manifests/controller.pp (revision 34) > +++ modules/openstack/manifests/controller.pp (revision 36) > @@ -135,6 +135,7 @@ > $cinder = true, > $cinder_db_user = 'cinder', > $cinder_db_dbname = 'cinder', > + $cinder_volume = 'cinder-volumes', > # quantum > $quantum = false, > $quantum_db_user = 'quantum', > @@ -290,6 +291,7 @@ > sql_connection => "mysql://${cinder_db_user}:${cinder_db_password}@ > ${db_host}/${cinder_db_dbname}?charset=utf8", > rabbit_password => $rabbit_password, > rabbit_userid => $rabbit_user, > + volume_group => $cinder_volume, > } > > class { 'cinder::api': > Index: modules/cinder/manifests/base.pp > =================================================================== > --- modules/cinder/manifests/base.pp (revision 34) > +++ modules/cinder/manifests/base.pp (revision 36) > @@ -11,7 +11,8 @@ > $rabbit_virtual_host = '/', > $rabbit_userid = 'nova', > $package_ensure = 'present', > - $verbose = 'False' > + $verbose = 'False', > + $volume_group = 'cinder-volumes' > ) { > > include cinder::params > @@ -51,6 +52,7 @@ > 'DEFAULT/sql_connection': value => $sql_connection; > 'DEFAULT/verbose': value => $verbose; > 'DEFAULT/api_paste_config': value => '/etc/cinder/api-paste.ini'; > + 'DEFAULT/volume_group': value => $volume_group; > } > > } > > -- > You received this message because you are subscribed to the Google Groups > "Puppet Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > Visit this group at http://groups.google.com/group/puppet-dev?hl=en. > For more options, visit https://groups.google.com/groups/opt_out. > > > -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/puppet-dev?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
