On Tue, Jun 25, 2013 at 6:06 PM, Eric Sorenson <[email protected] > wrote:
> Hi, there's been a lively discussion on an interesting pull request that > came in: > > https://github.com/puppetlabs/hiera/pull/137 > > In the interest of soliciting input from a wider audience I'd like to move > the discussion on this request to the list. > > Personally I have two issues, one major/semantic and one minor/syntactic. > > The major problem is that this seems to reverse the entire goal of > "separate data from code" by putting code back into data. In addition to > the issues @ripienaar raised in [the previous recursion PR]( > http://projects.puppetlabs.com/issues/18030#note-7) around > visibility/action-at-a-distance, this seems to make "more magic" and I feel > pretty strongly that we need less magic even if it comes at the expense of > more code -- in this case, a puppet manifest variable that does the > stringified variable interpolation you're proposing in the data. > I don't think this major problem is a problem. As you note we already support variable interpolation in Hiera. It only took me a couple of hours of doing something "serious" with Hiera to land in a situation where I wanted to interpolate another hiera value. I was genuinely surprised that I could interpolate scope variables but not other hiera variables. The minor problem is that, as Henrik notes, Hiera already has ONE syntax > for variable interpolation that uses a different sigil to Puppet's. That's > kind of weird, and again I'd like to see changes that bring the ecosystem > closer together, not push it further apart. > I don't particularly like new syntax, but I do think it's possible to make this work without introducing more magic or more syntax. What if we just used the existing sigil and searched the hiera hierarchy before searching the Puppet scope? Would this address the magic and syntax concerns? -Jeff -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/puppet-dev. For more options, visit https://groups.google.com/groups/opt_out.
