Hi, Am Mittwoch, 28. August 2013 19:53:42 UTC+2 schrieb Adrien Thebo: > > Moreover, by our current standards CFPropertyList is not a candidate for > vendoring. The general guideline for vendoring is that candidates must be > stable libraries, and should only be one or two libraries. In addition the > CFPropertyList doesn't seem particularly stable, as demonstrated by the > comment > https://github.com/puppetlabs/facter/pull/499#issuecomment-21770546 which > indicates that CFPropertyList may not be very stable. Having to continually > re-vendor that library inside of Facter is a special level of torment > that's normally reserved for people that take up two parking spaces with > one car >
I wish you could have sent some bug reports, especially for this „strange omissions and obsfucations.” I'm always eager to improve my code and my coding skills, but w/o feedback I can't fix anything :-) > But wait, there's more! > https://github.com/puppetlabs/facter/pull/513introduced a patch to > CFPropertyList to force the string encoding type for > Ruby compatibility. So on top of having to re-vendor the CFPropertyList to > handle updates, we would have to carry our own patches on top of everything > else. This means that the platform team will be forced to more or less > maintain this library. > Why don't you talk to me? Especially this pull request totally makes sense for me and I merged it as soon as I noticed it, see https://github.com/ckruse/CFPropertyList/commit/97e074fd8b3ffb6909235f44a2defe687dc09067 Regarding the original question: since I don't use puppet on OS X, I don't have a opinion on this point. I can just repeat: talk to me. Send me bug reports and/or pull requests. I'm always eager to improve code quality and fix bugs. Also see http://projects.puppetlabs.com/issues/21538#note-4 as well as http://projects.puppetlabs.com/issues/21538#note-4 Greetings, CK -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/puppet-dev. For more options, visit https://groups.google.com/groups/opt_out.
