On Fri, Dec 20, 2013 at 7:12 AM, DEGREMONT Aurelien < aurelien.degrem...@cea.fr> wrote:
> Le 20/12/2013 16:03, Felix Frank a écrit : > > On 12/20/2013 03:41 PM, DEGREMONT Aurelien wrote: >> >>> Assuming this patch is clean/adapted, is this something Puppet could >>> accept? or there is still other problems? >>> >> I can't really give a well founded comment on this. >> >> If this can be done in a way the doesn't regress other functionality, then we would definitely take a patch. Getting a speed improvement in a common case would be a great thing! > I like Jeff's approach in spirit, but as far as execution is concerned, >> my gut says that something more object oriented would be preferable. >> What I'm saying is, instead of enriching interfaces with values that >> need passing, an approach based on inheritance and method overrides >> might lead to better maintainability later on. >> > Agreed, but I think guidance from Puppet developers is needed for that. > > Either inheritance or delegation would be good in this case. I had the same reaction as Felix to the parameter being passed. > As far as I'm concern, I do not think I know the puppet code well enough > to do this alone. > This might be a good why to dive in and see if you can figure out a little more :). I think what you put out was a good proof of concept. Then what Jeff followed up with was a nice continuation. If I'm interpreting his last message correctly he has uncovered a few more consequences of changing the behavior. Investigating those might provide some insight into what needs to change and what needs to stay the same. I'm sorry if that is a little vague, but I'm not overly familiar with this part of the codebase either. > Aurélien > > > -- > You received this message because you are subscribed to the Google Groups > "Puppet Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to puppet-dev+unsubscr...@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/ > msgid/puppet-dev/52B45E67.2010709%40cea.fr. > > For more options, visit https://groups.google.com/groups/opt_out. > -- Andrew Parker a...@puppetlabs.com Freenode: zaphod42 Twitter: @aparker42 Software Developer *Join us at PuppetConf 2014, September 23-24 in San Francisco* -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-dev/CANhgQXsYv5jLOZuEYGfC34uBcPhZSEYUW30C5bwpWKxGrOic3Q%40mail.gmail.com. For more options, visit https://groups.google.com/groups/opt_out.
