Apparently I didn't post these last week. Surprise!

Pull request triage - 2014-04-09

Joined: Alex, Andy, Felix, Henrik, Joshua, Kylo, Rob, Adrien, Brian

Held over:

Puppet:

2309: Separate out hold state into a separate property:
  - Would rather see held stay as ensure and a version parameter pulled out.
  - Finch to add comment -- Adrien will start a puppet-dev conversation
  - Push to lollipopman to start puppet-dev convo
  - Conversation started, now we wait for a resolution
  - [link](https://groups.google.com/forum/#!topic/puppet-dev/_APn8ZXw4Cw)

2420: Disambiguation of handling source_or_content for fileservers vs local
re...
  - Specs don't make a lot of sense with respect to the issue being fixed
  - Joshua to pull into the sprint to sort that out. (2x)

1974: enablerepo and disablerepo for yum type:
  - Contributor seemed on board to the approach we suggested, let's see if
he follows up. If not we can just take this and fix it ourselves.
  - It's been 2 weeks since we've seen a response to this, it might be be
best if we just fixed it up ourselves. Probably won't be able to do it this
week though

2033: Implement feature :upgradeable for OpenBSD package provider.
  - This has been stalled for months now, Adrien to close.

2082: Add install options apt
  - Merged!

2136: For puppet4 (#11383) support purging of all cronjobs
  - Still on hold. Felix will look at getting a PR for a deprecation
warning.
  - Still waiting for the puppet-4 branch to continue forward on this. (2x)

2262 - Fix yum/rpm version comparison to work the way RPM actually does:
  - We'll take this into puppet 4.
  - Also waiting for the puppet-4 branch. (2x)

2436 - Use metadata.json as canonical metadata source.
  - Andy has decreed that if there are PMT code changes, the Forge team is
in charge.

2440 - Update `puppet module generate` to create `metadata.json`:
  - ditto

2452 - Make the digest algorithm used for file checksums configurable:
  - Looks very reasonable. We'll pull this in the next sprint as our big
item to consider from the PR submissions. (2x)

2492: (PUP-1381) issue warnings to current users of cron purging
  - See also: https://github.com/puppetlabs/puppet/pull/2136
  - More discussion has been had, Felix to continue to work on this

2495: Implement :enableable for OpenBSD service provider
  - Waiting on Zach to make minor changes

2494: Change Crypto Spec in accordance to bettercrypto.org
  - Waiting on Josh C to comment on
  - Pull into this week's sprint

2489: (PUP-2101) resource parser: add the resource name on the validation
erro...
  - Trivial fix to create_resources, needs fixes to specs and commit
message.
  - Charlie to take. (2x)

2488: (maint) Add travis notifications to #puppet-dev
  - merged then rolled back; it doesn't notify on pull requests so doesn't
buy us anything

2487: (PUP-2098) 'only_uid' property on resources 'user'
  - See also https://github.com/puppetlabs/puppet/pull/2484
  - This spiraled into a conversation about the resources resource and
resource purging. In short the behavior of purging depends on the resource
being purged, and the type can't really know about everything beforehand.
It might be better to either have a 'purge' type or modify the resources
type to have providers, and have a passthrough for provider specific
options.
  - Felix to comment on the PR

2485: (PUP-2096) Support alternate http client classes in http_pool
  - cprice wants to merge this into 3.5.1, we want to minimize the amount
of change in that fix to minimize risk of regressions.
  - We're looking at releasing 3.6.0 at the end of the month with lots of
small things, punting this issue till then.
  - Joshua to comment

Facter:

566: (#23269) Handle non-utf8 in dmidecode/smbios output
  - Merged!

580: (FACT-166) change acceptable fact names to be only lowercase Symbols
  - Skipping over for next week
  - Adrien to talk to jhoblitt

608: Fix to Virtual Machine detection on Darwin
  - Merged!

642/643: Fun with AIX networking
  - Fixing this up ourselves, bringing it into the sprint.
  - Adrien to follow up

New pull requests:

Facter:

559: (FACT-233) Add dhcp_server fact
  - Could use some additional commenting and review
  - Adrien to comment on, but won't necessarily pull into the sprint

560: (FACT-234) Add uuid_<partition>
  - Could use some additional commenting and review
  - Adrien to comment on, but won't necessarily pull into the sprint

595: Update detection of GCE instances
  - Requires backporting of GCE code onto facter-2, punting on this

621: debian/control: Depend on lsb-release.
  - This is a packaging question, less in our juristiction.
  - haus to comment on it

629: Make kernelmajversion useful in FreeBSD
  - Looks good, just needs an issue and we can merge it
  - Joshua to comment

630: Add LXC detection to virtual and is_virtual fact
  - Looks good, just needs to be rebased onto Facter
  - Joshua to comment

644: (#7559) Use /sys/hypervisor/version/extra to distinguish AWS VM in VPC
  - Superseded by https://github.com/puppetlabs/facter/pull/661
  - Adrien to comment.

658: Cumulus Linux distro to properly report Debian family
  - This has to land in master because we haven't backported the Cumulus
Linux
    changes back into facter-2.
  - Joshua to comment about the commit message, we'll merge in when it's
fixed.

659: Convert-Interface-Names: not replace : and .
  - This change is is more correct backwards incompatible, existing facts
will see their names change.
  - Adrien to comment

Candidates for the upcoming sprint:

  - 2452 - Make the digest algorithm used for file checksums configurable:
  - 2494: Change Crypto Spec in accordance to bettercrypto.org

Tasks broken out by person:

Adrien:
  - 2033: Implement feature :upgradeable for OpenBSD package provider.
  - 580: (FACT-166) change acceptable fact names to be only lowercase
Symbols
  - 642/643: Fun with AIX networking
  - 559: (FACT-233) Add dhcp_server fact
  - 560: (FACT-234) Add uuid_<partition>
  - 644: (#7559) Use /sys/hypervisor/version/extra to distinguish AWS VM in
VPC

Felix:
  - 2487: (PUP-2098) 'only_uid' property on resources 'user'

Zach:
  - 2495: Implement :enableable for OpenBSD service provider


-- 
Adrien Thebo | Puppet Labs

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/puppet-dev/CALVJ9SKc_aUvembiQM_2CbnSSsmRXzH-qqfkm8eLQrJghC6xeQ%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to