Pull request triage - 2014-04-23 Joined: Adrien, Andy, Josh, Rob, Ethan, Felix, Ken, Brian, Charlie
Held over: Puppet: 2309: Separate out hold state into a separate property: - Kylo to ping lollipopman about the decision and see if he wants to carry the change forward - [link](https://groups.google.com/forum/#!topic/puppet-dev/_APn8ZXw4Cw) - Decision made, waiting for contributor to update pull request. 2420: Disambiguation of handling source_or_content for fileservers vs local re... - Andy wants to make a few changes. Will pull in and make a few small changes (timeboxed to no more than a few hours) - Specs don't make a lot of sense with respect to the issue being fixed - Merged by Andy! 1974: enablerepo and disablerepo for yum type: - Contributor seemed on board to the approach we suggested, let's see if he follows up. If not we can just take this and fix it ourselves. - It's been 2 weeks since we've seen a response to this, it might be be best if we just fixed it up ourselves. Probably won't be able to do it this week though - Updated ourselves in GH-2560, closed by contributor 2136: For puppet4 (#11383) support purging of all cronjobs - Still on hold. Felix will look at getting a PR for a deprecation warning. - Still waiting for the puppet-4 branch to continue forward on this. (3x) 2262 - Fix yum/rpm version comparison to work the way RPM actually does: - We'll take this into puppet 4. - Also waiting for the puppet-4 branch. (2x) 2492: (PUP-1381) issue warnings to current users of cron purging - Sending back to felix with the suggestion that he try option 3. - Felix to keep tinkering on it, Andy to look more closely. 2495: Implement :enableable for OpenBSD service provider - Waiting on Zach to make minor changes - Merged! 2494: Change Crypto Spec in accordance to bettercrypto.org - Waiting on Josh C to comment on (Josh is out for a few weeks) - Josh is back, will review 2487: (PUP-2098) 'only_uid' property on resources 'user' - Adrien to close the PRs (2487 and 2484) (2x) 2515: Add support for 'skip_if_unavailable' to `yumrepo` - This will be a candidate for next sprint to go out in 3.6.0 - Rob to merge 2477: (PUP-2073) fix for multiple diff_args - Tests need to use File spec helpers - Merge commit need to be removed - Josh to comment, either fixup or close next week if no response 2473: (PUP-1775) Acquire and block for Yum's lock to prevent corruption - domcleal verified it works, Adrien to pull into this week's sprint 2530: (PUP-2237) Updates to Emacs puppet-mode for indentation, XEmacs, file name matching - RyanS to try it out and let us know - Merged! 2524: (maint) Clearer error message to reflect origin. - Asked Ashley to update the tests - Ethan to fixup/merge 2455: (PUP-2014) Make gem provider match on a single gem name - Adrien to ask contributor to add a test for the changed query - Josh to update with the file to 2470: Tickets/master/11263 (more options for yumrepo) - Adrien to comment and let the contributor know that things have been changing. Request for splitting it up into smaller pieces. - Waiting on contributor 2472: (PUP-2040) Allow excluding files from module build package - ping Alex or Ryan and ask where they want to take this. (2x) 2467: chkconfig should use resetpriorities when enabling services - Needs a ticket - Adrien commenting to point out some problems with this change - Waiting on response from contributor Facter: 580: (FACT-166) change acceptable fact names to be only lowercase Symbols - Skipping over for next week - Peter H. to close, figure out next steps 642/643: Fun with AIX networking - Fixing this up ourselves, bringing it into the sprint. - "/etc/ifconfig" doesn't seem to be present on modern - Already in sprint, sorting out what's going on 559: (FACT-233) Add dhcp_server fact - Looks pretty good, Adrien to pull in 560: (FACT-234) Add uuid_<partition> - Could use some additional commenting and review - Adrien to comment/close 595: Update detection of GCE instances - Requires backporting of GCE code onto facter-2 - Since we'll be overhauling this, Josh to close and comment 629: Make kernelmajversion useful in FreeBSD - Looks good, just needs an issue and we can merge it - Josh C to comment/possibly fixup 630: Add LXC detection to virtual and is_virtual fact - Looks good, just needs to be rebased onto Facter - Still needs rebase, Josh to ping Jeff 644: (#7559) Use /sys/hypervisor/version/extra to distinguish AWS VM in VPC - Superseded by https://github.com/puppetlabs/facter/pull/661 - Josh to comment since GH-661 was merged 658: Cumulus Linux distro to properly report Debian family - This has to land in master because we haven't backported the Cumulus Linux changes back into facter-2. - Peter H to rebase and merge 659: Convert-Interface-Names: not replace : and . - This change is is more correct but backwards incompatible, existing facts will see their names change. - Can't accept till Facter 3, Rob to close. New pull requests: 2466: (PUP-2029) Add a CatalogModel for Puppet 4x - Closing out now, revising closer to Puppet 4 2468: Add mechanism to allow template files to be copied without getting parsed - This is a modules/forge team, Adrien to ping everybody remotely related to the forge 2453: Add parser function digest, that calculates a checksum using the configured `digest_algorithm` - Based on top of GH-2452 which was rewritten, needs to be updated on top of 2537 - Comment that we're still working on prereqs 2532: (PUP-2240) Add unfold of array using splat unary * operator - Issue targeted at 3.7, deferring on this. 2478: (PUP-2074) resourses unless_uid depends on unless_system_user - Needs tests and could use a more comprehensive commit message 2479: (PUP-2031) unless_uid on user is completely broken wrt ranges - This removes pseudo ranges from unless_uid, adds comma separated values - Further simplify inputs to [String | Integer | Array<String | Integer>] - Peter to take 2536: (maint) Beaker tests useful for reviewing environment status - Andy and Joshua to follow up on as part of environment work 2525: (PUP-1942) Initial pass at a global scope - Andy to close 2549: (PUP-2298) add support for Type#in_valid_catalog? methods to transaction - What sort of hooks do we want to define over the application lifetime? - Implement validate method on Type ancestor class, change method name something like `#check_constraints` -- Adrien Thebo | Puppet Labs -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-dev/CALVJ9S%2BjuX%3DxA6QJq6wnDzhw3X2gOaOk91%2Bf7oWj5UtTLBo9_g%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
