Pull request triage - 2014-05-28
This triage time was spent trying to burn down the backlog of PRs where we
had already made decisions on. We spent nearly the entire time just working
on the final review, test, cleanup, and merge. No new PRs were covered.
Joined: Charlie, Ethan, Jeremy, JoshC, Kylo, Peter, Andy, JoshuaP
Candidates for merging:
- 2492: (PUP-1381) issue warnings to current users of cron purging
- Andy Merged
- 2549: (PUP-2298) add support for Type#in_valid_catalog? methods to
transaction
- Josh Merging
- 2577: (PUP-2356) Added some extra yumrepo options
- Charlie Reviewing
- 2547: (PUP-2454) Don't purge system users on OpenBSD
- Removing from candidate since it needs work from submitter after
some review.
- 559: (FACT-233) Add dhcp_server fact
- merged, but requires follow-up given there may need to be a new
ticket for F20
- Kylo merged followup
- 2616: (PUP-1070) Cleanup empty/invalid lock file
- Ethan Merging
- 2639: (PUP-1843) Restore hiera indirector terminus
- Joshua removing duplication and merging
Held over:
Puppet:
2492: (PUP-1381) issue warnings to current users of cron purging
- Sending back to felix with the suggestion that he try option 3.
- Felix to keep tinkering on it, Andy to look more closely.
- Ready for review, Andy to pull into sprint for 3.7.x
- Merged in during this PR triage meeting
2468 (PUP-2079): Add mechanism to allow template files to be copied without
getting parsed
- This is a modules/forge team, Adrien to ping everybody remotely related
to the forge
- The changes that were blocking this have landed. Kylo pinging pvande
again.
- Need to ping pvande again to verify / merge
- Still no response, will wait another week
2549: (PUP-2298) add support for Type#in_valid_catalog? methods to
transaction
- Adrien to ping Felix based on TravisCI failures
- Thumbs up, Adrien to pull into next sprint or two
- Kicked out of the 05/14 - 05/21 sprint, hopefully we'll get to it this
week
2501: (PUP-2569) (maint) Return last serial from SSL inventory
- Andy to log a ticket, continue discussion on ticket, e.g. revoke all
certificates for a specified name
- PR needs to be updated with issue # in commit, revoke all certificates
with a given name, preserve existing API
- Kylo to update pull request
2577: (PUP-2356) Added some extra yumrepo options
- Charlie to follow up with contributor on test failures
- Otherwise, Adrien and Charlie give this the +1
- PR spec tests updated, pulling into 05/21 - 05/28 sprint
2639: (PUP-1843) Restore hiera indirector terminus
- Andy commented that this duplicates code, waiting on Erik
2557: (PUP-2578) Unbreak OpenBSD services from packages which set local
flags
- Needs tests, Rob to comment
- Our current sprint is pretty full, won't be able to pull into this
week's sprint
- Sprint is still pretty full, deferring for another week
2558: (PUP-1069) upgradeable OpenBSD package provider
- Second PR to adding this functionality
- Adrien to comment in the PR that we want this but will need to defer
another week (2x)
2547: (PUP-2454) Don't purge system users on OpenBSD
- Current behavior is dangerous on OpenBSD & Debian, this would provide
incremental improvement
- Pull request updated for Debian but Debian system UIDs are 100 - 999,
comment added
- Peter worked on during the PR Triage. Jasper needs to fix up.
2605: (PUP-1381) Read all crontabs
- Felix to update PR with JIRA ticket for 4.0
- Felix to file separate deprecation_warning ticket for 3.7
- Felix to update pull request with points from triage discussion
2616: (PUP-1070) Cleanup empty/invalid lockfile
- Puppet used to use an empty lockfile to mean the agent is
administratively disabled
- Andy and Adrien to add comments
- Adrien to not overcommit us for another sprint, we're going to defer on
this.
2666: (maint) Resolve some documentation TODOs in Puppet::Type
- There are concerns about #uniqueness_key being public API, and composite
namevars are not well supported. We need to decide if we want to really
support those.
--
Andrew Parker
[email protected]
Freenode: zaphod42
Twitter: @aparker42
Software Developer
*Join us at PuppetConf 2014 <http://www.puppetconf.com/>, September
22-24 in San Francisco*
*Register by May 30th to take advantage of the Early Adopter discount
<http://links.puppetlabs.com/puppetconf-early-adopter> **—**save $349!*
--
You received this message because you are subscribed to the Google Groups
"Puppet Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/puppet-dev/CANhgQXvcW4JDfGM_AB145wQkA1MxyJT2LvARfwKh6t4JYezwUg%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
