On 06/10/2014 05:37 PM, Andy Parker wrote: > I feel like we've been falling behind in our pull request handling. > The hangouts on Wednesdays have been a great forum for talking over > and making decisions about them, but we haven't been too great about > actually following through all of the time. To be honest it is a > problem of cost :( It actually takes us a lot of effort to get changes > in. Most of this comes down to unforeseen consequences of the changes. > Some of this we discover in review (which takes time), some we > discover when all of our tests get to run against the changes. I'm not > sure what I can be done right now to lower the cost. The other > possibility is that I'm off base here and we are keeping up just fine :)
Well, I think the only new ones we tackled today were some Facter PRs and that on from cprice. So yes, we're getting relatively little headway (although, we *did* manage to merge many of the held over ones). Perhaps we need to keep a more strict discipline and not allow ourselves to get derailed, at least as long as there is a significant number of unreviewed PRs. Mind you, I do enjoy the side discussions and am prone to start those myself, still - we may want to restrict ourselves a little depending on the overall respective PR situation. Cheers, Felix -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-dev/5398BC19.2070607%40Alumni.TU-Berlin.de. For more options, visit https://groups.google.com/d/optout.
